babel-loader icon indicating copy to clipboard operation
babel-loader copied to clipboard

docs: add loadPartialConfig info in README

Open gaurav5430 opened this issue 5 years ago • 2 comments
trafficstars

To make it more clear that the options specified here override the existing babel config/

Please Read the CONTRIBUTING Guidelines In particular the portion on Commit Message Formatting

Please check if the PR fulfills these requirements

  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [x] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • [ ] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [x] Other... Please describe: changes to README

What is the current behavior? (You can also link to an open issue here) N/A

What is the new behavior? remains the same

Does this PR introduce a breaking change?

  • [ ] Yes
  • [x] No

If this PR contains a breaking change, please describe the following...

  • Impact:
  • Migration path for existing applications:
  • Github Issue(s) this is regarding:

Other information: related to https://github.com/babel/babel-loader/issues/823

gaurav5430 avatar Jun 22 '20 16:06 gaurav5430

I appreciate the added documentation, but writing "Kind of fixes #823" ensures this PR's merge will close that ticket. I don't believe this resolves the root problem I'm outlining in the issue.

kylemh avatar Jul 13 '20 14:07 kylemh

I appreciate the added documentation, but writing "Kind of fixes #823" ensures this PR's merge will close that ticket. I don't believe this resolves the root problem I'm outlining in the issue.

Sure, removed that. Thanks.

gaurav5430 avatar Aug 03 '20 20:08 gaurav5430