PlainTasks icon indicating copy to clipboard operation
PlainTasks copied to clipboard

Add theme: PlainTasks Markdown

Open ronilaukkarinen opened this issue 10 years ago • 7 comments

Ref: #244 https://github.com/aziz/PlainTasks/issues/244

ronilaukkarinen avatar Aug 27 '15 08:08 ronilaukkarinen

NAVER - http://www.naver.com/

[email protected] 님께 보내신 메일 <[PlainTasks] Add theme: PlainTasks Markdown (#246)> 이 다음과 같은 이유로 전송 실패했습니다.


받는 사람이 회원님의 메일을 수신차단 하였습니다.


stockerman7 avatar Aug 27 '15 08:08 stockerman7

It doesn’t support url scope, is it intentional? If yes, it’s okay, I just want to be sure.

It doesn’t support ST2:

error: Error loading colour scheme Packages/User/tasks-markdown.hidden-tmTheme: Error parsing plist xml: Failed to open file In file "Packages/User/tasks-markdown.hidden-tmTheme"

This is problem, we claim supprt for both ST so far (since 3 is still in beta), please ensure ST2 support, otherwise I have to reject.

vovkkk avatar Aug 27 '15 08:08 vovkkk

Not intentional and yeah, only ST3 supported for now. I was too hasty, so feel free to reject. Maybe getting back on to this in the future.

ronilaukkarinen avatar Aug 27 '15 08:08 ronilaukkarinen

@ronilaukkarinen I’m sorry, it is my mistake, it does support ST2 just fine, the reason for error is that I set wrong path (User instead of PlainTasks).

So if you want to add url scope, just go ahead, then ping me, and it’s good to merge.

vovkkk avatar Aug 27 '15 09:08 vovkkk

@vovkkk Ok, thanks for clarifying that, I don't have ST2 installed myself so wasn't sure. I'll add the url scope in some point and get back on this.

ronilaukkarinen avatar Aug 27 '15 09:08 ronilaukkarinen

Ooh, also there are bold and italic scopes, if you’ve missed them.

vovkkk avatar Aug 27 '15 09:08 vovkkk

Do you have a certain spec which scopes are needed? because I have created the scheme based on MarkdownEditing theme so I'm exactly not quite sure what else might be missing.

ronilaukkarinen avatar Aug 27 '15 09:08 ronilaukkarinen

        meta.tag.todo
        notes.todo
        punctuation.definition.bullet.completed
        punctuation.definition.bullet.pending
        punctuation.definition.bullet.cancelled
        meta.item.todo.cancelled
        meta.tag.todo.completed
        meta.tag.todo.cancelled
        meta.punctuation.archive.todo
        meta.punctuation.separator.todo
        punctuation.definition.italic
        todo.italic
        punctuation.definition.bold
        todo.bold
        todo.url
        string.other.tag.todo.today
        string.other.tag.todo.high
        string.other.tag.todo.low
        string.other.tag.todo.critical

vovkkk avatar Aug 27 '15 10:08 vovkkk