azerothcore-wotlk icon indicating copy to clipboard operation
azerothcore-wotlk copied to clipboard

(Scripts/Spells): Taunt Flag Targeting script uses hardcoded string.

Open heyitsbench opened this issue 1 year ago • 1 comments

Current Behaviour

Currently, the Taunt Flag Targeting script uses a hardcoded string.

https://github.com/azerothcore/azerothcore-wotlk/blob/e4136639e3b1ce4e4fc73204872d988588d60aee/src/server/scripts/Spells/spell_generic.cpp#L139

Expected Blizzlike Behaviour

This string should be contained in DB so it can be localized.

Source

I saw it in a dream

Steps to reproduce the problem

  1. Look at the script for the spell.
  2. Observe plain English text written in the file.

Extra Notes

No response

AC rev. hash/commit

e4136639e3b1ce4e4fc73204872d988588d60aee

Operating system

Windows 10 x64

Custom changes or Modules

mod-ptr-template

heyitsbench avatar Apr 03 '24 01:04 heyitsbench

Uses broadcast_text ID 28008.

heyitsbench avatar Apr 03 '24 01:04 heyitsbench