eslint-plugin-perfectionist icon indicating copy to clipboard operation
eslint-plugin-perfectionist copied to clipboard

feat(sort-objects): add custom-ignore to enable customizable ignore rule

Open KID-joker opened this issue 1 year ago • 3 comments

Description

fixes #126

Additional context

Because json-schema does not support function type, it is converted through object.


What is the purpose of this pull request?

  • [ ] Bug fix
  • [x] New Feature
  • [ ] Documentation update
  • [ ] Other

Before submitting the PR, please make sure you do the following

  • [x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • [x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • [x] Ideally, include relevant tests that fail without this PR but pass with it.
  • [x] Read contribution guidelines.

KID-joker avatar Apr 21 '24 02:04 KID-joker

The idea for such an option is a good one. But don't you think the customization is overly complicated? Perhaps it would be better to use just variable names instead of functions?

azat-io avatar Apr 24 '24 19:04 azat-io

I don't quite understand what you mean. How do variable names solve the problem?

KID-joker avatar Apr 24 '24 22:04 KID-joker

@KID-joker does it allow to exclude the files with specific name? can u prodive an example for it?

rtatarinov avatar Apr 25 '24 10:04 rtatarinov