cargo-dist icon indicating copy to clipboard operation
cargo-dist copied to clipboard

Apple Silicon (M1) macOS runners (aarch64)

Open xoolive opened this issue 1 year ago • 3 comments
trafficstars

So it seems Apple Silicon (M1) macOS runners are now available on GitHub Actions. https://github.com/orgs/community/discussions/69211

In the limitation section of https://opensource.axo.dev/cargo-dist/book/ci/github.html#bring-your-own-release you say:

GitHub currently only provides x86_64 macOS runners. When you request packages, the Intel versions will always be installed regardless of build targets. While Apple Silicon builds can use CLI tools installed this way, you will not be able to build software for Apple Silicon if it requires C libraries from Homebrew.

I guess things can be easily adapted so that releases with dependencies from Homebrew now work!

xoolive avatar Mar 20 '24 21:03 xoolive

Would it be enough to just edit that line (with macos-14)? https://github.com/axodotdev/cargo-dist/blob/80e4f88cd5d0fbfa9006334f0d5d3d532873fd05/cargo-dist/src/backend/ci/github.rs#L281

xoolive avatar Mar 20 '24 21:03 xoolive

so, i'll let @mistydemeo or @Gankra chime in, but iirc the issue here has to do with the minimum OS installed on each runner. unfortunately the macos-14 runner has a newer OS- so defaulting to it would actually be a breaking change- dropping compatibility for binaries that we currently can support with macos-12.

if you want you can always override the defaults using the github runner config: https://opensource.axo.dev/cargo-dist/book/reference/config.html#github-custom-runners

we definitely need to update that comment to be more accurate tho (and explain what i've said here more thoroughly)

ashleygwilliams avatar Mar 20 '24 21:03 ashleygwilliams

(oh also i think releases with dependencies from homebrew work now? @mistydemeo correct me if i'm wrong on that)

ashleygwilliams avatar Mar 20 '24 21:03 ashleygwilliams