liburing icon indicating copy to clipboard operation
liburing copied to clipboard

[GIT PULL] Change madvise test to use MADV_REMOVE

Open smuenzel opened this issue 1 year ago • 0 comments

Create an 8GB file initialized with 0xaa, punch a (8GB - page_size) hole using MADV_REMOVE, and check the contents. Requires support for FALLOC_FL_PUNCH_HOLE in the filesystem, which is checked for


git request-pull output:

The following changes since commit 3b4a7737ad6ffffc39390f8de9c109112633ae8c:

  Add 64-bit length variants of {f,m}advise (2024-06-01 13:06:53 -0600)

are available in the Git repository at:

  https://github.com/smuenzel/liburing advise

for you to fetch changes up to 1570cfdc494c9f38bac84f7fc837f69f99888ac0:

  Change madvise test to use MADV_REMOVE (2024-06-03 18:40:27 +0200)

----------------------------------------------------------------
Stefan Muenzel (1):
      Change madvise test to use MADV_REMOVE

 test/helpers.c |  39 ++++++++++++++++++++++++---------------
 test/madvise.c | 131 ++++++++++++++++++++++++++++++++++++++++-------------------------------------------------------------------------------------------
 2 files changed, 64 insertions(+), 106 deletions(-)

Click to show/hide pull request guidelines

Pull Request Guidelines

  1. To make everyone easily filter pull request from the email notification, use [GIT PULL] as a prefix in your PR title.
[GIT PULL] Your Pull Request Title
  1. Follow the commit message format rules below.
  2. Follow the Linux kernel coding style (see: https://github.com/torvalds/linux/blob/master/Documentation/process/coding-style.rst).

Commit message format rules:

  1. The first line is title (don't be more than 72 chars if possible).
  2. Then an empty line.
  3. Then a description (may be omitted for truly trivial changes).
  4. Then an empty line again (if it has a description).
  5. Then a Signed-off-by tag with your real name and email. For example:
Signed-off-by: Foo Bar <[email protected]>

The description should be word-wrapped at 72 chars. Some things should not be word-wrapped. They may be some kind of quoted text - long compiler error messages, oops reports, Link, etc. (things that have a certain specific format).

Note that all of this goes in the commit message, not in the pull request text. The pull request text should introduce what this pull request does, and each commit message should explain the rationale for why that particular change was made. The git tree is canonical source of truth, not github.

Each patch should do one thing, and one thing only. If you find yourself writing an explanation for why a patch is fixing multiple issues, that's a good indication that the change should be split into separate patches.

If the commit is a fix for an issue, add a Fixes tag with the issue URL.

Don't use GitHub anonymous email like this as the commit author:

[email protected]

Use a real email address!

Commit message example:

src/queue: don't flush SQ ring for new wait interface

If we have IORING_FEAT_EXT_ARG, then timeouts are done through the
syscall instead of by posting an internal timeout. This was done
to be both more efficient, but also to enable multi-threaded use
the wait side. If we touch the SQ state by flushing it, that isn't
safe without synchronization.

Fixes: https://github.com/axboe/liburing/issues/402
Signed-off-by: Jens Axboe <[email protected]>

By submitting this pull request, I acknowledge that:

  1. I have followed the above pull request guidelines.
  2. I have the rights to submit this work under the same license.
  3. I agree to a Developer Certificate of Origin (see https://developercertificate.org for more information).

smuenzel avatar Jun 03 '24 16:06 smuenzel