aws-mobile-appsync-sdk-js icon indicating copy to clipboard operation
aws-mobile-appsync-sdk-js copied to clipboard

Published 20 hours ago • verified publisher icon awslabs

feat: Handle AppSync Custom Domains

Open cadam11 opened this issue 3 years ago • 2 comments

Issue #, if available:

Fixes #517 for AppSync custom domains

Description of changes:

The issue was originally about supporting an arbitrary URL for websockets, but since AppSync now allows Custom Domains we should be able to rely on a simple replace to get the correct realtime url. This PR adds on one more replace call that appends /realtime to the url if it is not a default (i.e. *.amazonaws.com/graphql) url.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

cadam11 avatar Dec 30 '21 21:12 cadam11

Thanks! I need that as well! Custom domains are simply not working right now.

BigRedAllday avatar Apr 18 '22 15:04 BigRedAllday

This change is no longer relevant as aws-appsync-subscription-link v3.1.0 now supports custom domain.

almondheng avatar Sep 23 '22 10:09 almondheng