aws-innovation-sandbox icon indicating copy to clipboard operation
aws-innovation-sandbox copied to clipboard

Email regex in this repository does not match the code hosted in the solution's S3 bucket

Open gmatthew-umassd opened this issue 2 years ago • 1 comments

The regular expression used to check for valid email address: https://github.com/awslabs/aws-innovation-sandbox/blob/4c7b7279d0a75dd60b71b65c99c26275195204ab/source/Lambda/innovation_create_account_ou.py#L129 is different in the code that's hosted in this solution's S3 bucket: https://solutions-us-east-1.s3.amazonaws.com/aws-innovation-sandbox/v1.0.0/InnovationSandbox.zip

The version of the code referenced in the Solution's Implementation Guide and template: https://solutions-reference.s3.amazonaws.com/aws-innovation-sandbox/latest/aws-innovation-sandbox.template uses the outdated regular expressions, which causes email addresses with multiple delimiters to fail.

This issue was described and fixed in commit 36ee1c3.

gmatthew-umassd avatar Mar 20 '23 15:03 gmatthew-umassd

This issue just bit me too. Any plans to update the distribution to address this?

alexmarkley avatar Jan 17 '24 18:01 alexmarkley