Add kms_encryption_key_arn and cache_control parameters for s3 deploy

Open faridnsh opened this issue 2 years ago • 3 comments

Why?

Wanted to set kms_encryption_key_arn but it wasn't available. So decided add the two missing useful properties.

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Nov 02 '23 16:11 faridnsh

Hi @alFReD-NSH, could you look into the above review comments when you have time?

Dec 08 '23 11:12 sbkok

Hi @sbkok,

Thanks for the review. Raised some good points. I'll do the changes and make sure to test it out without the KMS, although maybe in couple of weeks.

Dec 12 '23 10:12 faridnsh

Hi @sbkok ,

After a long time, I managed to fix your points, also I realised I added the documentation for the source but not the deploy!

Anyway, just to be sure I tested it with and without the new properties and works perfectly.

Feb 22 '24 18:02 faridnsh