amazon-sqs-java-messaging-lib icon indicating copy to clipboard operation
amazon-sqs-java-messaging-lib copied to clipboard

JMSException is a little overused on concrete classes

Open jgangemi opened this issue 10 years ago • 1 comments

if the concrete implementation doesn't explicitly throw a JMSException, it does not need to be declared as part of the method signature. for example, SQSMessageConsumer.setMessageListener does not need to declare this exception.

i have a desire to use this implementation and i'm ok w/ using the SQS* classes directly (i'm wrapping them in other code). not having to deal w/ these exceptions when they aren't actually thrown would be helpful and help simplify the underlying code.

there also seems to be inconsistency in how RuntimeException subclasses are handled. in some cases, they are re-wrapped and re-thrown as JMSExceptions (bleh). in other cases, they are not.

jgangemi avatar Mar 18 '15 14:03 jgangemi

Marking as feature request to review the way exceptions are handled, rethrown and declared.

kuba-aws avatar Apr 25 '17 17:04 kuba-aws