amazon-kinesis-video-streams-webrtc-sdk-c icon indicating copy to clipboard operation
amazon-kinesis-video-streams-webrtc-sdk-c copied to clipboard

1.10.3

Open disa6302 opened this issue 1 year ago • 1 comments
trafficstars

Issue #, if available:

What was changed?

  • New release removing addConfigToServerList API that was introduced in 1.10.0.

Why was it changed?

  • To avoid enforcing samples to use this API to generate relay candidates.

How was it changed?

  • Reverted the commits that introduced this change. Restored unit tests too.

What testing was done for the changes?

  • Ran samples under different config to confirm nothing is broken.
  • Unit test

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

disa6302 avatar Jun 25 '24 19:06 disa6302

Codecov Report

Attention: Patch coverage is 0% with 155 lines in your changes missing coverage. Please review.

Project coverage is 75.09%. Comparing base (bfa6667) to head (096cafe). Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
samples/Common.c 0.00% 155 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2018      +/-   ##
==========================================
+ Coverage   74.81%   75.09%   +0.27%     
==========================================
  Files          46       48       +2     
  Lines       12119    13835    +1716     
==========================================
+ Hits         9067    10389    +1322     
- Misses       3052     3446     +394     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jun 25 '24 19:06 codecov-commenter

This PR includes bumping MBED TLS, which currently does not build previously on my Macbook (https://github.com/awslabs/amazon-kinesis-video-streams-webrtc-sdk-c/tree/master, commit ec75ba1)

Cloning into 'project_libmbedtls'...
HEAD is now at 1c54b5410 Merge pull request #786 from ARMmbed/dev/yanesca/mbedtls-2.25.0r0-pr
CMake Deprecation Warning at CMakeLists.txt:23 (cmake_minimum_required):
  Compatibility with CMake < 3.5 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.


/work/open-source/libmbedtls/build/src/project_libmbedtls/library/bignum.c:1547:29: error: variable 't' set but not used [-Werror,-Wunused-but-set-variable]
    mbedtls_mpi_uint c = 0, t = 0;
                            ^
1 error generated.
gmake[5]: *** [library/CMakeFiles/mbedcrypto.dir/build.make:174: library/CMakeFiles/mbedcrypto.dir/bignum.c.o] Error 1
gmake[4]: *** [CMakeFiles/Makefile2:166: library/CMakeFiles/mbedcrypto.dir/all] Error 2
gmake[3]: *** [Makefile:136: all] Error 2
gmake[2]: *** [CMakeFiles/project_libmbedtls.dir/build.make:87: build/src/project_libmbedtls-stamp/project_libmbedtls-build] Error 2
gmake[1]: *** [CMakeFiles/Makefile2:83: CMakeFiles/project_libmbedtls.dir/all] Error 2
gmake: *** [Makefile:91: all] Error 2
CMake Error at CMake/Utilities.cmake:75 (message):
  CMake step for libmbedtls failed: 2
Call Stack (most recent call first):
  CMakeLists.txt:163 (build_dependency)

After trying out this PR, it builds successfully.

2024-09-20 08:12:18,351 [INFO] [100%] Built target project_libmbedtls

sirknightj avatar Sep 20 '24 15:09 sirknightj