amazon-kinesis-video-streams-webrtc-sdk-c icon indicating copy to clipboard operation
amazon-kinesis-video-streams-webrtc-sdk-c copied to clipboard

support ice-lite

Open zhuker opened this issue 2 years ago • 5 comments
trafficstars

Issue #, if available:

Description of changes: Support ice-lite

ice-lite is a minimal version of the ICE specification, intended for servers running on a public IP address.

ice-lite is easy to implement, requiring the media server to only answer incoming STUN binding requests and acting as a controlled entity in the ICE process itself. This simplicity makes it quite popular among implementations of [SFUs] and other media servers.

Support for ice-lite is announced in the SDP as a=ice-lite.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

zhuker avatar Jul 17 '23 06:07 zhuker

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (863a1a4) 48.64% compared to head (4215d43) 48.64%. Report is 78 commits behind head on develop.

:exclamation: Current head 4215d43 differs from pull request most recent head 39d4e01. Consider uploading reports for the commit 39d4e01 to get more accurate results

Files Patch % Lines
src/source/PeerConnection/PeerConnection.c 75.00% 1 Missing :warning:
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1754   +/-   ##
========================================
  Coverage    48.64%   48.64%           
========================================
  Files           46       46           
  Lines        12099    12099           
========================================
  Hits          5886     5886           
  Misses        6213     6213           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jul 17 '23 14:07 codecov-commenter

cc @sirknightj

zhuker avatar Jul 17 '23 22:07 zhuker

@zhuker ,

Thank you for your contribution. I would like to run some end to end tests locally before reviewing this PR. Will update here once I have that going.

disa6302 avatar Jul 20 '23 15:07 disa6302

This is a very old issue. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to open a new one.

github-actions[bot] avatar Jan 29 '24 00:01 github-actions[bot]

This is a very old issue. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to open a new one.

github-actions[bot] avatar Jul 31 '24 00:07 github-actions[bot]

This is a very old issue. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to open a new one.

github-actions[bot] avatar Apr 20 '25 00:04 github-actions[bot]

Closing in favor of https://github.com/awslabs/amazon-kinesis-video-streams-webrtc-sdk-c/pull/2143 @disa6302

zhuker avatar May 31 '25 01:05 zhuker