sagemaker-python-sdk
sagemaker-python-sdk copied to clipboard
Update the numpy version to 2.0 and pandas version to 2.2.3
Issue #, if available:
Description of changes:
Testing done:
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General
- [ ] I have read the CONTRIBUTING doc
- [ ] I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
- [ ] I used the commit message format described in CONTRIBUTING
- [ ] I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
- [ ] I have updated any necessary documentation, including READMEs and API docs (if appropriate)
Tests
- [ ] I have added tests that prove my fix is effective or that my feature works (if appropriate)
- [ ] I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
- [ ] I have checked that my tests are not configured for a specific region or account (if appropriate)
- [ ] I have used
unique_name_from_baseto create resource names in integ tests (if appropriate) - [ ] If adding any dependency in requirements.txt files, I have spell checked and ensured they exist in PyPi
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Hi. Are you sure you want to pin exactly to numpy==2 in pyproject.toml? This is bound to create a lot of incompatibilities in downstream usage. Better to relax the constraint a bit IMHO.
Hi. Are you sure you want to pin exactly to numpy==2 in
pyproject.toml? This is bound to create a lot of incompatibilities in downstream usage. Better to relax the constraint a bit IMHO.
Agreed, that isn't the right thing to do. Currently in master a range of versions is supported (numpy>=1.9.0,<2). The best goal is to drop or increase the <2 part of that; so move to numpy>=1.9.0,<3 or numpy>=1.9.0,<2.5. This should not be too difficult, almost every other widely used project with a dependency on numpy has been able to do this. Typically what works in 2.0 also works in 1.2x. Worst case you may need some if-else constructs like https://numpy.org/devdocs/numpy_2_0_migration_guide.html#writing-numpy-version-dependent-code.