sagemaker-inference-toolkit icon indicating copy to clipboard operation
sagemaker-inference-toolkit copied to clipboard

Config parsing can be improved

Open ericangelokim opened this issue 6 years ago • 5 comments

https://github.com/aws/sagemaker-inference-toolkit/blob/master/src/sagemaker_inference/model_server.py#L42

This code here can be improved to add a config file, and not just use the mms default or env vars that are parsed.

The utils can include support to merge/override config files, instead of appending string values to write to file.

ericangelokim avatar Oct 23 '19 19:10 ericangelokim

thanks for the suggestion!

laurenyu avatar Oct 24 '19 01:10 laurenyu

+1

Currently it seems like only these 4 variables are able to be configured.

Having the ability to define your own config.properties would be nice (job_queue_size is particularly useful to me)

arvarik avatar Jun 07 '20 21:06 arvarik

For users less keen on updating config files, it would also be nice if these custom config values could be passed to start_model_server. If there is worry these values would be lost on restart, then Inference Toolkit could take care of writing these custom values out to a file on disk that can be re-used.

sanjams2 avatar Aug 31 '20 20:08 sanjams2

+1 When I'm trying to do inference for a file larger than 9M, the MMS will get stuck. And I found a solution in MMS github issue, configuring max_request_size. But I'm not able to do it. It would be really helpful it custom config file is supported.

ziweijiang avatar Sep 26 '21 21:09 ziweijiang

I come from here also looking to configure the job_queue_size: https://docs.aws.amazon.com/sagemaker/latest/dg/async-inference-troubleshooting.html

neo avatar Jan 24 '24 19:01 neo