karpenter-provider-aws icon indicating copy to clipboard operation
karpenter-provider-aws copied to clipboard

chore: add configurable ttl to post install hook

Open danielloader opened this issue 1 year ago • 3 comments
trafficstars

Fixes https://github.com/aws/karpenter-provider-aws/issues/6765

Description

Added configuration option for the ttlSecondsAfterFinished field on the post install job so that Argo CD based installs can complete (as Argo CD needs to reap the job rather than the internal controller).

How was this change tested?

Forked the chart, installed it with Argo CD with a value of 30 for .Values.postInstallHook.ttlSecondsAfterFinished.

Does this change impact docs?

  • [ ] Yes, PR includes docs updates
  • [ ] Yes, issue opened: #
  • [x] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

danielloader avatar Aug 15 '24 07:08 danielloader

Deploy Preview for karpenter-docs-prod ready!

Name Link
Latest commit f50ffb62da01d874960620528fcc2048257bf078
Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66c481e4678c420008eab373
Deploy Preview https://deploy-preview-6766--karpenter-docs-prod.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Aug 15 '24 07:08 netlify[bot]

Pull Request Test Coverage Report for Build 10400404075

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.327%

Totals Coverage Status
Change from base Build 10396139252: 0.0%
Covered Lines: 5921
Relevant Lines: 7464

💛 - Coveralls

coveralls avatar Aug 15 '24 16:08 coveralls

I had the same issues, please fix it

inclemenstv avatar Aug 16 '24 08:08 inclemenstv

Closing as the job has been removed.

danielloader avatar Aug 22 '24 17:08 danielloader