eks-anywhere icon indicating copy to clipboard operation
eks-anywhere copied to clipboard

Proposal: Workflow refactor

Open chrisdoherty4 opened this issue 3 years ago • 3 comments

View rendered proposal

Authors: Chris Doherty, Guillermo Gaston, Joey Wang, Eric Wollesen, Jacob Weinstock, Vivek Koppuru

chrisdoherty4 avatar Aug 03 '22 22:08 chrisdoherty4

Codecov Report

Merging #2869 (db3b888) into main (f914fb4) will increase coverage by 0.08%. The diff coverage is n/a.

:exclamation: Current head db3b888 differs from pull request most recent head 719bcda. Consider uploading reports for the commit 719bcda to get more accurate results

@@            Coverage Diff             @@
##             main    #2869      +/-   ##
==========================================
+ Coverage   61.26%   61.34%   +0.08%     
==========================================
  Files         323      323              
  Lines       26258    26336      +78     
==========================================
+ Hits        16086    16155      +69     
- Misses       8895     8901       +6     
- Partials     1277     1280       +3     
Impacted Files Coverage Δ
pkg/curatedpackages/packagecontrollerclient.go 96.10% <0.00%> (-3.90%) :arrow_down:
controllers/vsphere_datacenter_controller.go 11.86% <0.00%> (-2.89%) :arrow_down:
pkg/curatedpackages/packageinstaller.go 93.33% <0.00%> (-1.41%) :arrow_down:
controllers/factory.go 91.86% <0.00%> (-0.07%) :arrow_down:
pkg/config/config.go 100.00% <0.00%> (ø)
pkg/controller/clusters/registry.go 100.00% <0.00%> (ø)
pkg/dependencies/factory.go 66.19% <0.00%> (+0.98%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 03 '22 22:08 codecov[bot]

LGTM

g-gaston avatar Aug 04 '22 18:08 g-gaston

/approve

chrisdoherty4 avatar Aug 23 '22 13:08 chrisdoherty4

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrisdoherty4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

eks-distro-bot avatar Aug 23 '22 13:08 eks-distro-bot