aws-toolkit-azure-devops icon indicating copy to clipboard operation
aws-toolkit-azure-devops copied to clipboard

ECRPushImage warning in Azure Devops due to Node10 dependency

Open ganeshranfignum opened this issue 1 year ago • 1 comments

The ECRPushImage Task uses Node10 which is no longer supported . This causes a warning to be displayed on our build process in Azure Devops

##[warning]Task 'Amazon ECR Push' version 1 (ECRPushImage@1) is dependent on a Node version (10) that is end-of-life. Contact the extension owner for an updated version of the task. Task maintainers should review Node upgrade guidance: https://aka.ms/node-runner-guidance

ganeshranfignum avatar Sep 25 '24 12:09 ganeshranfignum

This isn't just limited to ECR - we're getting the same on AWSShellScript:

##[warning]Task 'AWS Shell Script' version 1 (AWSShellScript@1) is dependent on a Node version (10) that is end-of-life. Contact the extension owner for an updated version of the task. Task maintainers should review Node upgrade guidance: https://aka.ms/node-runner-guidance

I suspect the whole toolkit needs a v2 with a node update.

jbstans avatar Sep 25 '24 13:09 jbstans

AWS support ADO seems pretty dead. I wish I was stuck with ADO either :/

mhvelplund avatar Oct 28 '24 07:10 mhvelplund

I found out why they don't just bump the Node version. From PR #560:

Supporting node 16 requires bumping azure-pipelines-task-lib. We are currently blocked from doing this because this version bump uses a newer version of shelljs as a dependency, which produces runtime errors for our task. (see PR description in https://github.com/aws/aws-toolkit-azure-devops/pull/539 for more details).

mhvelplund avatar Oct 28 '24 10:10 mhvelplund

Just to add, also seeing this on SystemsManagerGetParameter@1 task too:

##[warning]Task 'AWS SSM Get Parameter' version 1 (SystemsManagerGetParameter@1) is dependent on a Node version (10) that is end-of-life. Contact the extension owner for an updated version of the task. Task maintainers should review Node upgrade guidance: https://aka.ms/node-runner-guidance

decampo04 avatar Oct 31 '24 08:10 decampo04

Just to add to the pile, we are seeing this on S3Upload, AWSShellScript.

We are also seeing the same on Terraform and Terraform-outputs. Different extensions, but the same issue.

seanezell avatar Nov 01 '24 22:11 seanezell

Same issue here for the AWSCLI, AWSShellScript, LambdaDeployFunction and ECRPushImage on our end. My guess is all the tasks for the aws-toolkit-azure-devops are affected by this.

JeroenBodeTriple avatar Nov 04 '24 09:11 JeroenBodeTriple

Seeing the same over in our org. No new information, just leaving this comment to help express the potential impact of this deprecation.

symnatbay avatar Nov 04 '24 23:11 symnatbay

Its a on going issue with AWS and Terraform , fixed terraform issue by upgrading its version But AWSShellScript , AWSCLI issue is consistent even after version upgrade

sameerahmed720 avatar Nov 05 '24 04:11 sameerahmed720

I'm seeing the same for S3Upload@1, SendMessage@1

isarastov avatar Nov 05 '24 14:11 isarastov

+1. Getting the same error for all tasks used from aws-toolkit-azure-devops. Would be good to know the timeline when it is expected to be upgraded.

tayalnishu avatar Nov 05 '24 14:11 tayalnishu

See https://github.com/jfrog/jfrog-azure-devops-extension/pull/518 for inspiration on addressing the issue. This seems to have worked for the JFrog marketplace extension, and the warning is no longer appearing.

ashokm avatar Nov 06 '24 11:11 ashokm

Anyone have an official Microsoft doc that states when they are pulling the plug on node v10?

I opened an AWS support ticket and I can tell you AWS is aware of this.

rynop avatar Nov 06 '24 15:11 rynop

I like to acknowledge that we are aware of this problem. In our past attempts to address this, we got blocked by a shelljs related JS bundler issue which prevented us from updating azure-pipelines-task-lib. We are looking into this again and will post an update once we have more information.

saurabhajmera avatar Nov 06 '24 23:11 saurabhajmera

I like to acknowledge that we are aware of this problem. In our past attempts to address this, we got blocked by a shelljs related JS bundler issue which prevented us from updating azure-pipelines-task-lib. We are looking into this again and will post an update once we have more information.

Is there a timeline when this is planned to be resolved?

adurangalvis avatar Nov 07 '24 14:11 adurangalvis

Is there a timeline when this is planned to be resolved?

Not yet, but we will share more information once we have an update. Thank you for your patience.

saurabhajmera avatar Nov 08 '24 19:11 saurabhajmera

Hey @saurabhajmera

Is there any updates regarding this ongoing issue ?

ajith-shan-m avatar Dec 03 '24 04:12 ajith-shan-m

@ajith-shan-m, We are actively working on a short-term solution, which we plan to release in the coming weeks. Addressing the shelljs issue in the long term, however, will require changes to the azure-pipelines-task-lib library, which is maintained by Microsoft. While we are in ongoing communication with Microsoft about this, we currently do not have a timeline for when the long-term fix will be available.

saurabhajmera avatar Dec 04 '24 16:12 saurabhajmera

We have updated the tasks to support Node 20 as per microsoft guidance. It is now released under version 1.18.0

hayemaxi avatar Dec 10 '24 22:12 hayemaxi

I have confirmed the warning has gone away. Thanks!

rynop avatar Dec 10 '24 22:12 rynop

Same here! Thanks!

On 10 Dec 2024, at 7:05 PM, Ryan Pendergast @.***> wrote:

I have confirmed the warning has gone away. Thanks!

— Reply to this email directly, view it on GitHub https://github.com/aws/aws-toolkit-azure-devops/issues/566#issuecomment-2533019467, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACJXS3GS2BNVT5WFAB6656T2E5QQ5AVCNFSM6AAAAABO2OVB4KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMZTGAYTSNBWG4. You are receiving this because you are subscribed to this thread.

mateofd avatar Dec 10 '24 22:12 mateofd

Also confirmed, thank you!

Hektor-V avatar Dec 10 '24 22:12 Hektor-V

The warning is gone in 1.18.0, thank you!

isarastov avatar Dec 10 '24 22:12 isarastov

The warning is gone now! Thank you

ajith-shan-m avatar Dec 11 '24 06:12 ajith-shan-m

I can see in my pipeline that it lists 1.18

Task         : Amazon S3 Upload
Description  : Upload file and folder content to an Amazon Simple Storage Service (S3) Bucket on AWS
Version      : 1.18.0

But I still seeing it using node10\bin\node.exe in an error we are facing. Is this change dependent on anything other than just having the newest version of the task?

mingo-eric avatar Dec 17 '24 19:12 mingo-eric

I can see in my pipeline that it lists 1.18

Task         : Amazon S3 Upload
Description  : Upload file and folder content to an Amazon Simple Storage Service (S3) Bucket on AWS
Version      : 1.18.0

But I still seeing it using node10\bin\node.exe in an error we are facing. Is this change dependent on anything other than just having the newest version of the task?

The change allows agents to use node 20 to run the tasks, so it seems likely that your agent either does not have node 20 installed or it is not the default. AFAIK, in most cases microsoft-hosted agents should already have node20 installed and used by default, while on-prem agents will need to be manually updated (if not already done so by now).

Can you verify the agent it is running on has node 20 and it's the default? Try using the Node JS installer task in your pipeline before running the AWS tasks. If you still see this, please open a new issue.

hayemaxi avatar Dec 24 '24 16:12 hayemaxi