aws-toolkit-azure-devops icon indicating copy to clipboard operation
aws-toolkit-azure-devops copied to clipboard

AWS S3Upload task add --sync or equivalent operation

Open coffeedome opened this issue 4 years ago • 2 comments

Describe the bug

Task isn't overwriting files that already exist

To reproduce

Run S3 Upload task in yaml pipeline to a bucket with a target file that already exists.

Expected behavior

Existing files should be overwritten.

Screenshots

Your Environment

  • On-prem or cloud based?: Cloud
  • Azure DevOps version: Cloud
  • AWS Toolkit for Azure DevOps version: Cloud

Additional context

coffeedome avatar Mar 16 '21 21:03 coffeedome

Hello, can you provide additional information like logs?

The toolkit just uses an S3 PutObjectRequest which will always overrides unless the bucket is versioned, so I'm struggling to think that it could cause an issue with that

hunterwerlla avatar Mar 16 '21 22:03 hunterwerlla

I'd assume the bug report is incorrectly written, the package successfully copies and replaces files with the same object name. But if an object is deleted at the source (e.g. an Azure DevOps repo), the destination S3 bucket doesn't perform the same action since, as intended. This is only copying the files, it's not performing sync with the additional --delete parameter.

The reporter may not have noticed the above and that the S3 object has changed names between source/destination.

j0nathontayl0r avatar Apr 19 '21 08:04 j0nathontayl0r