aws-sdk-js-v3 icon indicating copy to clipboard operation
aws-sdk-js-v3 copied to clipboard

test(protocoltests): string list header bindings that require quoting

Open trivikr opened this issue 1 year ago • 1 comments
trafficstars

Issue

Fixed in https://github.com/smithy-lang/smithy/pull/1049

Description

Enables protocol tests for string list header bindings that require quoting

Testing

CI


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

trivikr avatar Apr 18 '24 20:04 trivikr

Error

  ● RestJsonInputAndOutputWithQuotedStringHeaders:Request

    expect(received).toBe(expected) // Object.is equality

    Expected: "\"b,c\", \"\\\"def\\\"\", a"
    Received: "b,c, \"def\", a"

      3521 |
      3522 |     expect(r.headers["x-stringlist"]).toBeDefined();
    > 3523 |     expect(r.headers["x-stringlist"]).toBe('"b,c", "\\"def\\"", a');
           |                                       ^
      3524 |
      3525 |     expect(r.body).toBeFalsy();
      3526 |   }

      at Object.<anonymous> (test/functional/restjson1.spec.ts:3523:39)

  ● RestJsonInputAndOutputWithQuotedStringHeaders:Response

    expect(received).toBe(expected) // Object.is equality

    Expected: true
    Received: false

      3915 |   Object.keys(paramsToValidate).forEach((param) => {
      3916 |     expect(r[param]).toBeDefined();
    > 3917 |     expect(equivalentContents(r[param], paramsToValidate[param])).toBe(true);
           |                                                                   ^
      3918 |   });
      3919 | });
      3920 |

      at test/functional/restjson1.spec.ts:3917:67
          at Array.forEach (<anonymous>)
      at Object.<anonymous> (test/functional/restjson1.spec.ts:3915:33)

trivikr avatar Apr 18 '24 20:04 trivikr

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

github-actions[bot] avatar Sep 28 '24 00:09 github-actions[bot]