aws-sdk-go-v2 icon indicating copy to clipboard operation
aws-sdk-go-v2 copied to clipboard

Replacement for ecs.WaitUntilServicesStable

Open skyzyx opened this issue 4 years ago • 2 comments

Confirm by changing [ ] to [x] below to ensure that it's a bug:

Describe the bug

Migrating a project from v0.24.0 → v1.3.2. For ECS, there were 4 waiters (services running/stopped, tasks running/stopped), but the latest release only has 3 of those waiters. The one missing is for services running.

Here is the doc link for the waiter that no longer exists: https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/[email protected]#Client.WaitUntilServicesStable

Version of AWS SDK for Go?

$ cat go.mod | grep "github.com/aws"
	github.com/aws/aws-sdk-go-v2 v1.3.2
	github.com/aws/aws-sdk-go-v2/config v1.1.5
	github.com/aws/aws-sdk-go-v2/credentials v1.1.5
	github.com/aws/aws-sdk-go-v2/service/ecs v1.2.2
	github.com/aws/aws-sdk-go-v2/service/sts v1.2.2

Version of Go (go version)?

$ go version
go version go1.16.2 darwin/amd64

Additional context:

It's the same as this in the AWS CLI v2:

aws ecs wait services-stable --cluster {cluster} --services {list-of-services}

skyzyx avatar Apr 09 '21 20:04 skyzyx

Just ran into the same issue a few months later. Versions:

$ cat go.mod | grep "github.com/aws"
        github.com/aws/aws-sdk-go-v2 v1.8.0
        github.com/aws/aws-sdk-go-v2/config v1.6.0
        github.com/aws/aws-sdk-go-v2/feature/s3/manager v1.4.0
        github.com/aws/aws-sdk-go-v2/service/applicationautoscaling v1.4.2
        github.com/aws/aws-sdk-go-v2/service/autoscaling v1.11.0
        github.com/aws/aws-sdk-go-v2/service/ecr v1.4.2
        github.com/aws/aws-sdk-go-v2/service/ecs v1.8.0
        github.com/aws/aws-sdk-go-v2/service/s3 v1.12.0

Are there any plans to reimplement this waiter as it sure looks like it was an oversight?

AlfredDobradi avatar Aug 26 '21 08:08 AlfredDobradi

Ping. Just a friendly 7½ month check-in.

skyzyx avatar Nov 24 '21 00:11 skyzyx

Hi @skyzyx , Im so sorry for the late reply.

I see that ecs client version 1.18.9 has that waiter added back.

Closing the issue. If you need any future help please @ me and I'll do my best to respond in a timely manner.

Thank you! Ran~

RanVaknin avatar Sep 11 '22 03:09 RanVaknin

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see. If you need more assistance, please either tag a team member or open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so.

github-actions[bot] avatar Sep 11 '22 03:09 github-actions[bot]