aws-sdk-cpp icon indicating copy to clipboard operation
aws-sdk-cpp copied to clipboard

Smoke Tests Codegen Working

Open sbera87 opened this issue 1 year ago • 1 comments

Issue #, if available:

Description of changes:

Check all that applies:

  • [x] Did a review by yourself.
  • [ ] Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • [ ] Checked if this PR is a breaking (APIs have been changed) change.
  • [ ] Checked if this PR will not introduce cross-platform inconsistent behavior.
  • [ ] Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • [x] Linux
  • [x] Windows
  • [ ] Android
  • [ ] MacOS
  • [ ] IOS
  • [ ] Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

sbera87 avatar Oct 18 '24 22:10 sbera87

Left some comments, have some concerns around exception handling and the structure of some of the operations. but overall the execution pattern looks good, just need to refactor some things.

also in the future make sure to remove commented code, system outs, and white space changes before marking the PR as ready to review

Addressed all the comments that were brought up. If there are some things missed, I will address

sbera87 avatar Oct 25 '24 18:10 sbera87