aws-sdk-cpp icon indicating copy to clipboard operation
aws-sdk-cpp copied to clipboard

Call `find_dependency(CURL)` if the Curl client is enabled.

Open teo-tsirpanis opened this issue 1 year ago • 2 comments

Description of changes:

This PR updates the exported config file to call find_dependency(CURL) if the Curl client had been enabled when building the SDK.

Check all that applies:

  • [X] Did a review by yourself.
  • [ ] Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • [ ] Checked if this PR is a breaking (APIs have been changed) change.
  • [ ] Checked if this PR will not introduce cross-platform inconsistent behavior.
  • [ ] Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • [x] Linux
  • [x] Windows
  • [ ] Android
  • [ ] MacOS
  • [ ] IOS
  • [ ] Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

teo-tsirpanis avatar May 28 '24 11:05 teo-tsirpanis

Why exactly do you need this added to the cofig file? This looks like an ok change, but we want to make sure we understand what your use case is

jmklix avatar Jun 28 '24 19:06 jmklix

aws-cpp-sdk-core sometimes depends on the CURL::libcurl target but until now, that target is not guaranteed to exist. By finding Curl when we find the AWS SDK, we guarantee that the Curl targets exist if needed.

teo-tsirpanis avatar Jun 30 '24 16:06 teo-tsirpanis