aws-sdk-cpp icon indicating copy to clipboard operation
aws-sdk-cpp copied to clipboard

Fix failure to call curl[c-ares]

Open jimwang118 opened this issue 1 year ago • 0 comments

Issue #, if available: After installing curl's feature c-ares on arm64-osx, there will be a problem that c-ares cannot be linked when installing aws-sdk-cpp[core,s3,transfer]. You can also refer to the specific questions of 36661. Description of changes: Modified the curl calling method, using the module mode of cmake to call curl. Check all that applies:

  • [X] Did a review by yourself.
  • [ ] Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • [ ] Checked if this PR is a breaking (APIs have been changed) change.
  • [ ] Checked if this PR will not introduce cross-platform inconsistent behavior.
  • [ ] Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • [ ] Linux
  • [X] Windows
  • [ ] Android
  • [X] MacOS
  • [ ] IOS
  • [ ] Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

jimwang118 avatar Apr 17 '24 02:04 jimwang118