aws-sdk-cpp icon indicating copy to clipboard operation
aws-sdk-cpp copied to clipboard

Tracing miss span context with transfer manager or thread executor

Open lyrq opened this issue 2 years ago • 1 comments

Describe the feature

Current implementation of tracing creates a span context from opentelemetry::context::RuntimeContext::GetCurrent() This is a thread_local stack of previous span context.

When getting an object through the transfer manager or with GetObjectCallable or GetObjectAsync the span will be created from another thread than the one doing the request. There is no way to link or give the right parent to the span created in S3Client::GetObject.

Could you provide a way to propagate the right context like opentelemetry propagator is doing between client / server with http headers?

Use Case

I can't correlate smithy tracing span in S3Client GetObject with my code Exemple:

             main thread                                                   thread executor
| Span A |(application)
   | Span B | (TransferManager::DownloadFile)
                 | Span D | (Proccess Data)                           | Span C | (GetObject)

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • [ ] I may be able to implement this feature request
  • [X] This feature might incur a breaking change

lyrq avatar Oct 27 '23 15:10 lyrq

Thanks for using this sdk and taking the time to open this feature request. We do want to add support for this, but this is not a high priority currently. I will make sure to update here when we add support

jmklix avatar Oct 30 '23 19:10 jmklix