aws-sdk-cpp icon indicating copy to clipboard operation
aws-sdk-cpp copied to clipboard

S3::URI

Open dvirtz opened this issue 5 years ago • 4 comments

Issue #1507

Description of changes:

  • refactor Http::URI to a generic Net::URI.
  • add S3::S3URI class.
  • both Http::URI and S3::S3URI derive from Net::URI.

Check all that applies:

  • [x] Did a review by yourself.
  • [x] Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • [ ] Checked if this PR is a breaking (APIs have been changed) change.
  • [ ] Checked if this PR will not introduce cross-platform inconsistent behavior.
  • [ ] Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • [ ] Linux
  • [ ] Windows
  • [ ] Android
  • [x] MacOS
  • [ ] IOS
  • [ ] Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

dvirtz avatar Nov 25 '20 21:11 dvirtz

I'll be happy to get some hints about if and how to update documentation.

dvirtz avatar Nov 30 '20 13:11 dvirtz

Hi @dvirtz , Can you provide some background on why this change is necessary? Like, what problem are you having that this fixes?

KaibaLopez avatar Nov 30 '20 19:11 KaibaLopez

The background is shortly described in the attached issue, but to reiterate I'm getting an S3 URI from my library's clients and in order to call the S3 API I need to parse that URI into bucket, key etc. The added S3URI class solves that.

dvirtz avatar Nov 30 '20 19:11 dvirtz

Greetings! Sorry to say but this is a very old issue that is probably not getting as much attention as it deservers. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to open a new one.

github-actions[bot] avatar Apr 20 '22 00:04 github-actions[bot]

Closing this because this is change is not backwards compatible

jmklix avatar Aug 30 '22 18:08 jmklix