aws-cli icon indicating copy to clipboard operation
aws-cli copied to clipboard

Add warning for invalid max-items value

Open aemous opened this issue 1 year ago • 1 comments

Description of changes: Explicitly warn users that we do not support non-positive values for the max-items global pagination argument.

Example output:

aws s3api list-objects --bucket bucket-123 --max-items 0
warning: Non-positive values for --max-items may result in undefined behavior.

{
    "RequestCharged": null
} 

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

aemous avatar Sep 18 '24 21:09 aemous

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 0.08%. Comparing base (f70e1e3) to head (8da209c). Report is 22 commits behind head on develop.

Files with missing lines Patch % Lines
awscli/customizations/paginate.py 0.00% 6 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #8931      +/-   ##
==========================================
- Coverage     0.08%   0.08%   -0.01%     
==========================================
  Files          210     210              
  Lines        16902   16911       +9     
==========================================
  Hits            14      14              
- Misses       16888   16897       +9     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Sep 18 '24 21:09 codecov-commenter