aws-cli icon indicating copy to clipboard operation
aws-cli copied to clipboard

Replace outdated bucket placeholders with updated example buckets.

Open DavidSouther opened this issue 1 year ago • 4 comments

Issue #, if available:

There is an internal effort to rename placeholder BUCKET_NAMES with reserved bucket_names across AWS docs.

Description of changes:

Performed an update across example files using sed -I '' -f .../buckets.sed **/*.rst from the examples folder.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

DavidSouther avatar Sep 13 '24 20:09 DavidSouther

Script was

s/DOC-EXAMPLE-BUCKET/amzn-s3-demo-bucket/g
s/DOC-EXAMPLE-BUCKET1/amzn-s3-demo-bucket1/g
s/DOC-EXAMPLE-BUCKET2/amzn-s3-demo-bucket2/g
s/DOC-EXAMPLE-BUCKET3/amzn-s3-demo-bucket3/g
s/DOC-EXAMPLE-SOURCE-BUCKET/amzn-s3-demo-source-bucket/g
s/DOC-EXAMPLE-DESTINATION-BUCKET/amzn-s3-demo-destination-bucket/g
s/DOC-EXAMPLE-SOURCE-BUCKET1/amzn-s3-demo-source-bucket1/g
s/DOC-EXAMPLE-DESTINATION-BUCKET1/amzn-s3-demo-destination-bucket1/g
s/DOC-EXAMPLE-SOURCE-BUCKET2/amzn-s3-demo-source-bucket2/g
s/DOC-EXAMPLE-DESTINATION-BUCKET2/amzn-s3-demo-destination-bucket2/g
s/DOC-EXAMPLE-LOGGING-BUCKET/amzn-s3-demo-logging-bucket/g
s/DOC-EXAMPLE-LOGGING-BUCKET1/amzn-s3-demo-logging-bucket1/g
s/DOC-EXAMPLE-LOGGING-BUCKET2/amzn-s3-demo-logging-bucket2/g
s/DOC-EXAMPLE-WEBSITE-BUCKET/amzn-s3-demo-website-bucket/g
s/DOC-EXAMPLE-WEBSITE-BUCKET1/amzn-s3-demo-website-bucket1/g
s/DOC-EXAMPLE-WEBSITE-BUCKET2/amzn-s3-demo-website-bucket2/g
s/DOC-EXAMPLE-BUCKET--usw2-az1--x-s3/amzn-s3-demo-bucket--usw2-az1--x-s3/g
s/DOC-EXAMPLE-BUCKET1--usw2-az1--x-s3/amzn-s3-demo-bucket1--usw2-az1--x-s3/g
s/DOC-EXAMPLE-BUCKET2--usw2-az1--x-s3/amzn-s3-demo-bucket2--usw2-az1--x-s3/g
s/DOC-EXAMPLE-BUCKET3--usw2-az1--x-s3/amzn-s3-demo-bucket3--usw2-az1--x-s3/g
s/DOC-EXAMPLE-SOURCE-BUCKET--usw2-az1--x-s3/amzn-s3-demo-source-bucket--usw2-az1--x-s3/g
s/DOC-EXAMPLE-DESTINATION-BUCKET--usw2-az1--x-s3/amzn-s3-demo-destination-bucket--usw2-az1--x-s3/g
s/DOC-EXAMPLE-SOURCE-BUCKET1--usw2-az1--x-s3/amzn-s3-demo-source-bucket1--usw2-az1--x-s3/g
s/DOC-EXAMPLE-DESTINATION-BUCKET1--usw2-az1--x-s3/amzn-s3-demo-destination-bucket1--usw2-az1--x-s3/g
s/DOC-EXAMPLE-SOURCE-BUCKET2--usw2-az1--x-s3/amzn-s3-demo-source-bucket2--usw2-az1--x-s3/g
s/DOC-EXAMPLE-DESTINATION-BUCKET2--usw2-az1--x-s3/amzn-s3-demo-destination-bucket2--usw2-az1--x-s3/g

DavidSouther avatar Sep 13 '24 20:09 DavidSouther

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 0.08%. Comparing base (f70e1e3) to head (7e798a8). Report is 224 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #8919      +/-   ##
==========================================
- Coverage     0.08%   0.08%   -0.01%     
==========================================
  Files          210     210              
  Lines        16902   16911       +9     
==========================================
  Hits            14      14              
- Misses       16888   16897       +9     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Sep 18 '24 20:09 codecov-commenter

Commenting for posterity. Spoke to David offline about fixing some of the regex replacements.

elysahall avatar Sep 23 '24 16:09 elysahall

Looks like a couple stragglers found with git grep -l '[^\/:]amzn.*bucket':

s/awsamzn-s3-demo-bucket/amzn-s3-demo-bucket/gi
s/MY-S3-amzn-s3-demo-bucket/amzn-s3-demo-bucket/gi

DavidSouther avatar Sep 23 '24 16:09 DavidSouther