aws-cli icon indicating copy to clipboard operation
aws-cli copied to clipboard

Fix: adjust cloudformation package behaviour to disable uploading when inline code provided

Open qingchm opened this issue 3 years ago • 1 comments

Issue #, if available: https://github.com/aws/aws-cli/pull/7359

Description of changes: 22/11/10 Rebasing the latest changes and creating a new PR.

"The root cause of the issue above is how AWS CLI disregards inline code properties and creates a url to upload. This pr aims to fix the behaviour and treat serverless function resource with InlineCode property and lambda function resource with ZipFile property as special cases to skip the upload and set property process. The mirroring fixes in SAM CLI were released in v1.16.0."

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

qingchm avatar Nov 10 '22 23:11 qingchm

Codecov Report

Merging #7422 (a2d497c) into develop (9e9de3c) will decrease coverage by 0.00%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           develop   #7422      +/-   ##
==========================================
- Coverage     0.08%   0.08%   -0.01%     
==========================================
  Files          205     205              
  Lines        16457   16495      +38     
==========================================
  Hits            14      14              
- Misses       16443   16481      +38     
Impacted Files Coverage Δ
...customizations/cloudformation/artifact_exporter.py 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Nov 10 '22 23:11 codecov-commenter