aws-cdk icon indicating copy to clipboard operation
aws-cdk copied to clipboard

feat(ses): add configurationSetArn property on configurationSet resource

Open fredericbarthelet opened this issue 1 year ago • 7 comments

Issue

Closes #29902

Reason for this change

Adds configurationSetArn property on ConfigurationSet construct to ease up building Policy referencing such construct

Description of changes

Similar implementation to recently added emailIdentityArn property on EmailIdentity construct. The implementation leverages the use of stack.formatArn to build AWS::SES::ConfigurationSet arn

Description of how you validated changes

Did not add any test as this would basically mean testing formatArn function itself.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

fredericbarthelet avatar Apr 19 '24 09:04 fredericbarthelet

Exemption Request

  • Change to a README file: only the auto-generated doc for ConfigurationSet construct is affected by this PR
  • Change to a test file: testing this would feel like testing formatArn method

fredericbarthelet avatar Apr 19 '24 09:04 fredericbarthelet

@nmussy thanks for your review.

I deduplicated the code and added unit tests. Let me know if I should add any additional changes.

Thanks :) !

fredericbarthelet avatar Apr 23 '24 21:04 fredericbarthelet

Any chance a maintainer can review and weigh in on the decision to keep or remove the @attribute annotation on configurationSetArn :)? @nmussy should I ping anybody in particular on this PR? Thanks

fredericbarthelet avatar May 07 '24 07:05 fredericbarthelet

They'll address it when they review the PR 👍

nmussy avatar May 07 '24 07:05 nmussy

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

aws-cdk-automation avatar May 11 '24 00:05 aws-cdk-automation

@nmussy any chance this PR can be reviewed before end of the week? It will apparently automatically be closed otherwise (see https://github.com/aws/aws-cdk/pull/29903#issuecomment-2105398263). Thanks in advance for your help on that matter :)

fredericbarthelet avatar May 13 '24 11:05 fredericbarthelet

You need to file an exemption request comment to address the issues, see this comment. And I can't speak to review delays, I'm not a part of the CDK team, just a community member 👍

nmussy avatar May 13 '24 13:05 nmussy

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 205cce7f7d5a32fe41f3f04caeeaaf04868548d6
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation avatar May 14 '24 12:05 aws-cdk-automation

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

aws-cdk-automation avatar May 19 '24 00:05 aws-cdk-automation

The pull request linter fails with the following errors:

❌ Features must contain a change to a README file.
❌ Features must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

✅ A exemption request has been requested. Please wait for a maintainer's review.

aws-cdk-automation avatar May 19 '24 00:05 aws-cdk-automation