aws-cdk icon indicating copy to clipboard operation
aws-cdk copied to clipboard

chore(pr-linter): use octokit client for auth

Open TheRealAmazonKendra opened this issue 3 years ago • 3 comments
trafficstars

Testing this time from a branch instead of directly to our repository. Initially making this 'fix' so it will fail the linter.


All Submissions:

Adding new Unconventional Dependencies:

  • [ ] This PR adds new unconventional dependencies following the process described here

New Features

  • [ ] Have you added the new feature to an integration test?
    • [ ] Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

TheRealAmazonKendra avatar Sep 21 '22 19:09 TheRealAmazonKendra

gitpod-io[bot] avatar Sep 21 '22 19:09 gitpod-io[bot]

This might not be necessary anymore after https://github.com/aws/aws-cdk/pull/22194 ?

rix0rrr avatar Sep 22 '22 15:09 rix0rrr

This might not be necessary anymore after #22194 ?

Only the part that changes the identity back to aws-cdk-automation. I'll edit it so that only that change is still a thing.

TheRealAmazonKendra avatar Sep 25 '22 18:09 TheRealAmazonKendra

@Mergifyio update

TheRealAmazonKendra avatar Sep 26 '22 14:09 TheRealAmazonKendra

update

☑️ Nothing to do

  • [ ] #commits-behind>0 [:pushpin: update requirement]
  • [X] -closed [:pushpin: update requirement]

mergify[bot] avatar Sep 26 '22 14:09 mergify[bot]

@Mergifyio rebase

TheRealAmazonKendra avatar Sep 26 '22 14:09 TheRealAmazonKendra

rebase

☑️ Nothing to do

  • [ ] any of:
    • [ ] #commits-behind>0 [:pushpin: rebase requirement]
    • [ ] -linear-history [:pushpin: rebase requirement]
  • [X] -closed [:pushpin: rebase requirement]

mergify[bot] avatar Sep 26 '22 14:09 mergify[bot]

@Mergifyio update

TheRealAmazonKendra avatar Sep 26 '22 14:09 TheRealAmazonKendra

update

✅ Branch has been successfully updated

mergify[bot] avatar Sep 26 '22 14:09 mergify[bot]

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 6db52f0df6e0d2eaca2fc8f0e6d753da74181466
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation avatar Sep 26 '22 14:09 aws-cdk-automation

Not sure why this is failing and not actually getting the updated code from main so I'm going to close this one and reopen a new one from a new branch.

TheRealAmazonKendra avatar Sep 26 '22 14:09 TheRealAmazonKendra