amazon-vpc-resource-controller-k8s icon indicating copy to clipboard operation
amazon-vpc-resource-controller-k8s copied to clipboard

Ability to use Security Group Name and/or tags in Security Group Policy

Open abhipth opened this issue 4 years ago • 7 comments

Is your feature request related to a problem? Please describe. Security Groups are tied to VPC which means you cannot reuse Security Group Policy on clusters belonging to different VPC.

Describe the solution you'd like SGP should allow specifying security groups using security group name and/or tags.

abhipth avatar Feb 12 '21 17:02 abhipth

This will make reviewing PRs much easier.

swade1987 avatar Feb 15 '21 13:02 swade1987

Just to add to this, it would make using security groups defined in the EC2 ack usable - as it is, we can't reference a constructed security group automatically unless we can refer to it by name or pull it from a configMap - it'd be great if I could have a single helm chart define the security groups and the SGP instead of having to define at least one of them out-of-band or by external tooling.

jdnurmi avatar Sep 28 '22 10:09 jdnurmi

@jdnurmi has a great point about ACK integration - something like this would be very useful not only for SecurityGroupPolicy, but also for other places that require a security group, for example ENIConfig

Aleksei-Poliakov avatar Aug 24 '23 21:08 Aleksei-Poliakov

I opened a PR for this but not sure who I should engage to see where we are on supporting this feature

GnatorX avatar Mar 29 '24 17:03 GnatorX

@sjastis @hao for viz..

jayanthvn avatar Mar 29 '24 17:03 jayanthvn

I was literally just looking for this feature. Makes it way easier to assign when you generate the SGs automatically in terraform. Having to pick out the ID by hand is a pain and not stable if it gets destroyed

mattbrandman avatar Mar 30 '24 01:03 mattbrandman

Hey wanted to check in since I haven't seen any update in the PR or the issue. Where are we in supporting this with the PR?

GnatorX avatar Apr 05 '24 23:04 GnatorX