amazon-vpc-cni-k8s icon indicating copy to clipboard operation
amazon-vpc-cni-k8s copied to clipboard

Published 20 hours ago • verified publisher icon aws

Filter Managed ENI.

Open orsenthil opened this issue 1 year ago • 0 comments
trafficstars

What type of PR is this?

Feature

Which issue does this PR fix?:

https://github.com/aws/amazon-vpc-cni-k8s/issues/2875

What does this PR do / Why do we need it?:

If the SG reconciler runs before the ENI/IP reconciler it will modify the security groups as the ENI/IP reconciler hasn't had a chance to check the tags on the ENI yet.

Without relying on cache, when the SG reconciler is run, it will not update the ENI with the node.k8s.amazonaws.com/no_manage: true tag

Testing done on this change:

  • [ ] Unit Tests are successful.
  • [ ] Integration Tests need to be verified.

Current Mocks do not verify this.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

orsenthil avatar Apr 25 '24 21:04 orsenthil