amazon-vpc-cni-k8s icon indicating copy to clipboard operation
amazon-vpc-cni-k8s copied to clipboard

Published 20 hours ago • verified publisher icon aws

Added config map for env vars

Open nithu0115 opened this issue 5 years ago • 10 comments

Issue #, if available: N/A

Description of changes: Moved all env vars to a configmap to persist these variable during CNI update

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

nithu0115 avatar Jul 13 '20 21:07 nithu0115

Hi,

what's the current state here? In the last month it was pushed only release to release.

dschunack avatar Jul 27 '21 12:07 dschunack

As well as rebasing, this PR probably needs to have the Helm chart support added, which has appeared in this repo via #1271 since this PR was originally created.

TBBle avatar Aug 19 '21 11:08 TBBle

Hi @TBBle.

Yes once we add the config map support we need to fix the helm for config map.

@dschunack, With config maps along + DaemonSet there is no vanilla k8s support for rolling upgrade when config map is modified. We are working on this and should have some updates in the following weeks.

jayanthvn avatar Aug 19 '21 17:08 jayanthvn

What's the current milestone for this PR? This gets even more urgent now that for eg. in order to allow nodes having more Pods we need to enable an environment variable ( see https://aws.amazon.com/blogs/containers/amazon-vpc-cni-increases-pods-per-node-limits/ ).

Having a ConfigMap would help here instead of running a custom kubectl set env command on each installation ( and which also can't be automated via Terraform... ).

Thanks!

julianxhokaxhiu avatar Nov 30 '21 11:11 julianxhokaxhiu

Hi @jayanthvn ,

What's the current state of this PR?

dschunack avatar Jan 31 '22 14:01 dschunack

Any updates on this issue? It is rather cumbersome for us to use hacky config management with Terraform (kubectl provider, local null resources, etc) and not to mention needing to bounce nodes when this style of management fails (as it does a little too frequently).

mlschindler avatar May 27 '22 14:05 mlschindler

Any Update?

dschunack avatar Jun 17 '22 13:06 dschunack

This pull request is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days

github-actions[bot] avatar Sep 21 '22 17:09 github-actions[bot]

Still waiting on this

dschunack avatar Sep 22 '22 07:09 dschunack

Using ConfigMap to source environment variables for CNI is being tracked as a v2.x task, as rolling update with ConfigMap + daemonset pod needs more investigation. In the meantime, kubectl set env is the recommended mechanism.

This PR will not merge as is, but will be left open for those tracking. #2102 is the associated the issue, so please track this going forward.

jdn5126 avatar Oct 04 '22 15:10 jdn5126

This pull request is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days

github-actions[bot] avatar Dec 04 '22 00:12 github-actions[bot]