amazon-gamelift-plugin-unreal icon indicating copy to clipboard operation
amazon-gamelift-plugin-unreal copied to clipboard

Code Analysis definition breaks MSVC builds

Open BARBCallumT opened this issue 1 year ago • 1 comments

The following definition in AWSSDK.Build.cs causes compilation issues when using MSVC. This is due to the code analysis macro CA_ASSUME() trying to use __builtin_expect on Windows if __clang_analyzer__ is defined at all (regardless of if it's set to 0)

if (Target.Type == TargetRules.TargetType.Editor || Target.Type == TargetRules.TargetType.Client)
{
	PublicDefinitions.Add("AWS_USE_IO_COMPLETION_PORTS=1");
-	PublicDefinitions.Add("__clang_analyzer__=0");
+	// PublicDefinitions.Add("__clang_analyzer__=0");
	PublicDefinitions.Add("AWS_DEEP_CHECKS=0");

I would recommend removing this line from the build config.

BARBCallumT avatar Oct 23 '24 14:10 BARBCallumT