aws-security-reference-architecture-examples icon indicating copy to clipboard operation
aws-security-reference-architecture-examples copied to clipboard

Lambda-Layer is missing in packeging with parameter --solution-directory[BUG]

Open h1-h opened this issue 2 years ago • 1 comments

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Describe the bug

If i use the script stage_solution.sh with the parameter solution-directory the layer_code folder is muissing.

To Reproduce

Steps to reproduce the behavior:

  1. Try to execute: ./sra/utils/packaging_scripts/stage_solution.sh --solution_directory $CURRENT_FOLDER/sra/solutions/guardduty/guardduty_org --staging_bucket_name "sra-staging-$AWS_ACCOUNT-eu-central-1" $WITH_PROFILE
  2. It will not call the function: package_and_stage_solutions instead this function package_and_stage_common_solutions will be called, which is depends on the following if: if [ "$solution_directory" != "none" ]; then

Expected behavior

Even if we pass the parameter solution-directory that the folder layer_code is created.

Additional context

The executed code block: https://github.com/aws-samples/aws-security-reference-architecture-examples/blob/main/aws_sra_examples/utils/packaging_scripts/stage_solution.sh#L401C1-L430C3

h1-h avatar Jul 17 '23 15:07 h1-h

We will take a look at this issue and get back to you. Thank you for reporting it @h1-h

cyphronix avatar Jul 17 '23 21:07 cyphronix