aws-cdk-examples icon indicating copy to clipboard operation
aws-cdk-examples copied to clipboard

Quicksight automation with CDK - I did it and want to contribute it to the examples

Open gmournos opened this issue 2 years ago • 5 comments
trafficstars

Describe the feature

Hi,

I wrote an article to help the community to automate Quicksight assets generation (https://medium.com/@gmournos/aws-quicksight-as-code-a-unified-approach-for-quicksight-development-and-deployment-using-aws-30bbb6bd253a) and created a public repo (https://github.com/gmournos/quicksight-as-code) that automates the generation of the AWS samples provided by Quicksight.

I would like to contribute it here...

Use Case

Deploying Quicksight with CDK is a much better approach than the ones proposed by AWS, using cross account templates. For a full list of benefits, look at section 1.1. of my article (https://medium.com/@gmournos/aws-quicksight-as-code-a-unified-approach-for-quicksight-development-and-deployment-using-aws-30bbb6bd253a)

Proposed Solution

I already implemented everything in https://github.com/gmournos/quicksight-as-code, I just want to contribute it here.

The solution is a unified approach, containing L2 constructs, CLI scripts, utilities etc as described in my article (https://medium.com/@gmournos/aws-quicksight-as-code-a-unified-approach-for-quicksight-development-and-deployment-using-aws-30bbb6bd253a)

Other Information

No response

Acknowledgements

  • [X] I may be able to implement this feature request
  • [ ] This feature might incur a breaking change

Language

Typescript

gmournos avatar Jun 28 '23 10:06 gmournos

Looks great, let's do it. I've done a bit of QuickSight development and automation/repeatability has been a struggle. One request I have is to add as many code comments as you can - we want this repo to be a good data source for generative AI tools and it helps to have descriptive comments above code blocks.

ericzbeard avatar Jul 14 '23 16:07 ericzbeard

i guess we begin to sit on a example of quicksight/cdk code as well. Different usecase. We could provide a very basic example as well. If that is something that is in need.

sebs avatar Jul 18 '24 22:07 sebs

Actually, I have a full framework for this. Forgot to contribute it, but I have some time this weekend, so I will comment it and contribute it.

gmournos avatar Jul 20 '24 03:07 gmournos

And here is the PR [https://github.com/aws-samples/aws-cdk-examples/pull/1059]. Sorry for taking so long to contribute this. I forgot about it and thought I did it last year.

Happy reviewing

gmournos avatar Jul 20 '24 09:07 gmournos

We are cooking a 'easy' example as well and maybe that more complex onw from @gmournos makes sense with it as context. We stuck to the basics and it should be as briefly as it can get.

https://github.com/MaibornWolff/aws-cdk-examples/tree/ts-quicksight-example

sebs avatar Oct 09 '24 10:10 sebs

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see. If you need more assistance, please either tag a team member or open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so.

github-actions[bot] avatar Dec 28 '24 23:12 github-actions[bot]