Fixed issue #174

[GeneUNCG]

Fixed issue #174

[Krxtopher]

@GeneUNCG, thanks for the contribution! I've reviewed and tested your PR. There's one problem I'm experiencing that is easy to fix. When I attempt to run npm run start-babylon I get the following error:

[webpack-cli] TypeError: cli.isMultipleCompiler is not a function
    at Command.<anonymous> (/Users/schultkr/Documents/Git/amazon-sumerian-hosts/node_modules/webpack-cli/node_modules/@webpack-cli/serve/lib/index.js:146:35)
    at async Promise.all (index 1)
    at async Command.<anonymous> (/Users/schultkr/Documents/Git/amazon-sumerian-hosts/node_modules/webpack-cli/lib/webpack-cli.js:1672:7)

This problem is resolved if, use a clean version of this branch, I:

1. Delete the "package-lock.json" file at the root of the repo.
2. Run npm install, thus generating a new "package-lock.json" file.
3. Try running npm run start-babylon again.

Can you please regenerate that "package-lock.json" file and commit the new version as part of your PR?

P.S. I don't think you introduced this error. I noticed the problem was introduced with the latest commit in the "mainline2.0" branch.

[GeneUNCG]

@GeneUNCG, thanks for the contribution! I've reviewed and tested your PR. There's one problem I'm experiencing that is easy to fix. When I attempt to run npm run start-babylon I get the following error:

[webpack-cli] TypeError: cli.isMultipleCompiler is not a function
    at Command.<anonymous> (/Users/schultkr/Documents/Git/amazon-sumerian-hosts/node_modules/webpack-cli/node_modules/@webpack-cli/serve/lib/index.js:146:35)
    at async Promise.all (index 1)
    at async Command.<anonymous> (/Users/schultkr/Documents/Git/amazon-sumerian-hosts/node_modules/webpack-cli/lib/webpack-cli.js:1672:7)

This problem is resolved if, use a clean version of this branch, I:

1. Delete the "package-lock.json" file at the root of the repo.
2. Run npm install, thus generating a new "package-lock.json" file.
3. Try running npm run start-babylon again.

Can you please regenerate that "package-lock.json" file and commit the new version as part of your PR?

P.S. I don't think you introduced this error. I noticed the problem was introduced with the latest commit in the "mainline2.0" branch.

Hey @Krxtopher, thank you for reviewing my PR. Yes, I am getting the same issue as you, even with a fresh clone of this repository. I modified this file online, but I can create a separate commit submitting the package-lock.json if you would like.

EDIT: I am unsure how to resolve this error, I am assuming we would need to update the webpack-cli package?

[Krxtopher]

You shouldn't have to modify anything by hand. Just follow the steps I describe above, and then commit the new "package-lock.json" file that gets generated.

[trusktr]

I had this issue too, and it is not related to this pull request.

The best solution in my opinion is to pin the versions of webpack libs that we need until we're ready to explicitly update them. Here's a PR with the fix:

• https://github.com/aws-samples/amazon-sumerian-hosts/pull/181

If that goes in first, this PR will work fine.

[theVoiceMouse]

npm update webpack-cli fixes this temporarily for anyone seeing the problem until this PR gets committed

[trusktr]

Also this branch,

• #183

removes the webpack build (only Karma testing still uses webpack because Karma is too old (no longer maintained) to understand JS modules, but the configuration is much simplified), converts to everything to vanilla JavaScript modules, and all the examples work without any build needed (just run a static web server with npm start). The only problem left to solve is to fix Babylon animations that broke with the Babylon v5+ upgrade:

• #155

After the Babylon fix, vanilla JS modules will be good to go.

This will make maintenance of sumerian easier; people can get started without annoying build/dependency hiccups, and people can bundle their apps any way they see fit on their end.