quickstart-microsoft-sql icon indicating copy to clipboard operation
quickstart-microsoft-sql copied to clipboard
verified publisher icon aws-quickstart

Breaking change in SqlServerDsc needs attention in Reconfigure-SQL-DSC.ps1

Open sql-sith opened this issue 5 years ago • 3 comments

The SqlScript and SqlScriptQuery resources in version 13.5.0 and earlier of SqlServerDsc have a single parameter for the server and instance name called ServerInstance. However, beginning in version 14.0.0, there are separate parameters for the server and the instance called ServerName and InstanceName.

I'd be happy to send a PR to you, but I am curious how you want it to be handled. One approach would be to have code that checks the version of SqlServerDsc and then branches as needed to use one syntax or the other. Alternatively, the code could force version 14 to be installed/imported before Reconfigure-SQL-DSC.ps1 needs these resources.

Thoughts?

sql-sith avatar Jun 21 '20 02:06 sql-sith

I see that this has been handled in https://github.com/aws-quickstart/quickstart-microsoft-sql/pull/77. My apologies for not looking there first!

sql-sith avatar Jun 21 '20 02:06 sql-sith

I am reopening this because https://github.com/aws-quickstart/quickstart-microsoft-sql/pull/77 did not update this script.

sql-sith avatar Jun 22 '20 15:06 sql-sith

failed for me too.

nsingh308 avatar Feb 26 '21 19:02 nsingh308