quickstart-microsoft-sql icon indicating copy to clipboard operation
quickstart-microsoft-sql copied to clipboard

Make certificate creation idempotent

Open kjhosein opened this issue 6 years ago • 2 comments

Description of changes: Make certificate creation idempotent or it will generate new certs each time it's run.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

kjhosein avatar Jul 08 '19 01:07 kjhosein

Testing Now for a sanity check, will accept once test completes.

virtlima avatar Jul 19 '19 14:07 virtlima

@sql-sith - unfortunately, this was a long time back, so I don't remember all the details.

I had a situation where the install-sql-modules.ps1 script was being re-run, and it was problematic the 2nd time if the cert was already there. This patch simply checks if it's there, and if not, creates it, otherwise it skips it.

As for the branching/dev/etc., I followed this guide: https://aws-quickstart.github.io/option2.html

HTH!

kjhosein avatar Feb 01 '20 02:02 kjhosein