cdk-eks-blueprints icon indicating copy to clipboard operation
cdk-eks-blueprints copied to clipboard

Enhancing `CoreAddon` with Newer features.

Open elamaran11 opened this issue 3 years ago • 2 comments

Describe the feature

Enhancing CoreAddon to support Installation of New Addons with following :

Making Version Property Optional to support upcoming Addons Such as ADOT which does have a version number parameter. Also adding a logic to make sure addon creation works with or without version field. Adding a new field saName to make sure CoreAddon does not populate the AddonName with SA Name. Some Addons require a separate saName for the addon to work perfectly. Adding a new field namespace field to support creation of Service Accounts in required namespace. Today all Service Accounts needs by Addons are created in kube-system namespace.

Use Case

Enables us to support new EKS Addons and Observability Addons such as AMP, CloudWatch, Xray.

Proposed Solution

Enhancing CoreAddon to support Installation of New Addons with following :

Making Version Property Optional to support upcoming Addons Such as ADOT which does have a version number parameter. Also adding a logic to make sure addon creation works with or without version field. Adding a new field saName to make sure CoreAddon does not populate the AddonName with SA Name. Some Addons require a separate saName for the addon to work perfectly. Adding a new field namespace field to support creation of Service Accounts in required namespace. Today all Service Accounts needs by Addons are created in kube-system namespace.

Other Information

No response

Acknowledgements

  • [X] I may be able to implement this feature request

CDK version used

2.33

EKS Blueprints Version

1.1.0

Node.js Version

18.6.0

Environment details (OS name and version, etc.)

mac

elamaran11 avatar Jul 29 '22 01:07 elamaran11

@elamaran11 I assume this has been addressed and published in 1.1.0 and 1.2.0, correct?

shapirov103 avatar Aug 15 '22 20:08 shapirov103

@shapirov103 Yes this is addressed now.

elamaran11 avatar Aug 16 '22 01:08 elamaran11

Closing this issue @shapirov103

elamaran11 avatar Mar 02 '23 16:03 elamaran11