AWS Node Termination Handler supports MngClusterProvider either

[vumdao]

Describe the feature

I would like to use MngClusterProvider as a cluster provider to install AWS NTH but got following error.

    assert(asgCapacity && asgCapacity.length > 0, 'AWS Node Termination Handler is only supported for self-managed nodes');

The reason is that AsgClusterProvider does not allow to specify node capacity type

Use Case

Use spot instance capacity for EKS nodegroups

Proposed Solution

No response

Other Information

No response

Acknowledgements

• [ ] I may be able to implement this feature request

CDK version used

2.20.0

EKS Blueprints Version

2.20.0

Node.js Version

v16.13.0

Environment details (OS name and version, etc.)

Ubuntu

[shapirov103]

@vumdao based on the guidance from the service team, node termination handler is not needed for MNG because it gracefully handles interrupts out of the box. More info here.

Also ASG group supports spotPrice. It does not seem to be the cleanest way, however the doc states that "Spot Instances are launched when the price you specify exceeds the current Spot market price."

[vumdao]

@shapirov103 you might misunderstand this issue. When I create EKS blueprint and add MngClusterProvider at the clusterProvider, it's ok with out NTH add-on, but not ok when include NTH add as it raises the error

    assert(asgCapacity && asgCapacity.length > 0, 'AWS Node Termination Handler is only supported for self-managed nodes');

What I expect here is that we can use MngClusterProvider at the clusterProvider for all add-ons. Why is there condition check that muse use AsgProvider when inclunding NTH Add-on?

[vumdao]

@shapirov103 You still think that we install NTH just to manage auto scaling groups, we use NTH to support using Karpenter instead.

[shapirov103]

@vumdao I understand the issue, I believe we have a similar one in https://github.com/aws-quickstart/cdk-eks-blueprints/issues/441. We will address.

[github-actions[bot]]

This issue has been automatically marked as stale because it has been open 60 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

[github-actions[bot]]

Issue closed due to inactivity.