terraform-aws-eks-blueprints-addons icon indicating copy to clipboard operation
terraform-aws-eks-blueprints-addons copied to clipboard

Helm Provider has a breaking change >= 3.0.0

Open bushong1 opened this issue 5 months ago • 21 comments

Description

Helm Provider has released a breaking change that affects this module.

This module has the helm provider version set to >= 2.9, but should probably be set to ~> 2.9 to prevent major version bumps.

If your request is for a new feature, please use the Feature request template.

  • [x] ✋ I have searched the open/closed issues and my issue is not listed.

Versions

  • Module version [Required]:

  • Terraform version: tofu 1.9.0

  • Provider version(s):

+ provider registry.opentofu.org/cloudposse/awsutils v0.20.1
+ provider registry.opentofu.org/cloudposse/template v2.2.0
+ provider registry.opentofu.org/cloudposse/utils v1.30.0
+ provider registry.opentofu.org/hashicorp/aws v5.100.0
+ provider registry.opentofu.org/hashicorp/cloudinit v2.3.7
+ provider registry.opentofu.org/hashicorp/helm v3.0.0
+ provider registry.opentofu.org/hashicorp/http v3.5.0
+ provider registry.opentofu.org/hashicorp/kubernetes v2.37.1
+ provider registry.opentofu.org/hashicorp/local v2.5.3
+ provider registry.opentofu.org/hashicorp/null v3.2.4
+ provider registry.opentofu.org/hashicorp/random v3.7.2
+ provider registry.opentofu.org/hashicorp/time v0.13.1
+ provider registry.opentofu.org/hashicorp/tls v4.1.0

Reproduction Code [Required]

Run an init/upgrade on any code for this module.

Expected behaviour

It plans.

Actual behaviour

Plan fails

│ Error: Unsupported block type
│ 
│   on .terraform/modules/foo_eks.foo_eks_addons.eks_blueprints_kubernetes_addons.vpa/main.tf line 75, in resource "helm_release" "this":
│   75:   dynamic "set_sensitive" {
│ 
│ Blocks of type "set_sensitive" are not expected here.

bushong1 avatar Jun 18 '25 19:06 bushong1

Fix #453

rkonrath-bc avatar Jun 18 '25 22:06 rkonrath-bc

This is going to impact all the previous releases as well.

dunefro avatar Jun 19 '25 05:06 dunefro

@rkonrath-bc @dunefro fix seems to have been merged to main, but there is no release build/tag available which includes this fix - is there any eta for this please?

carlcauchi avatar Jun 24 '25 15:06 carlcauchi

Wait, now we need a major release to support Helm Provider >= 3 ... :)

lorengordon avatar Jul 17 '25 15:07 lorengordon

Soo... Is anyone working yet on updating this module for compatibility with helm provider v3? I could be willing to do the work, if the pr would likely be accepted...

lorengordon avatar Jul 31 '25 20:07 lorengordon

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

github-actions[bot] avatar Aug 31 '25 00:08 github-actions[bot]

Really not stale, still need support for helm provider v3...

lorengordon avatar Aug 31 '25 00:08 lorengordon

I use this module with terragrunt, setting this in root.hcl helped

terraform {
  required_providers {
    ...
    helm = {
      source  = "hashicorp/helm"
      version = "~> 2.9.0"
    }
  }
}

Fokines avatar Sep 12 '25 09:09 Fokines

We're experiencing the same issue and need to support the v3 Helm provider.

paultung avatar Sep 15 '25 10:09 paultung

Any update on this open issue? Appreciate it

MatteoNDR avatar Sep 17 '25 08:09 MatteoNDR

This issue should definitely get the highest priority

LeoSpyke avatar Sep 18 '25 13:09 LeoSpyke

Sorry about replying to this open bug again but does anyone have managed to solve it in some ways or have any updates?

Appreciate it

MatteoNDR avatar Sep 24 '25 15:09 MatteoNDR

Here's a draft PR to upgrade the Helm provider to v3: https://github.com/aws-ia/terraform-aws-eks-blueprints-addons/pull/472

This depends on https://github.com/aws-ia/terraform-aws-eks-blueprints-addon/pull/42 to be merged first.

dennisameling avatar Sep 25 '25 20:09 dennisameling

Hi @dennisameling thanks for your feedback, gonna follow the PR.

Have a good day

MatteoNDR avatar Sep 26 '25 07:09 MatteoNDR

@askulkarni2 @bryantbiggs this change needs some attention please.

NicholasRaymondiSpot avatar Sep 29 '25 14:09 NicholasRaymondiSpot

Unfortunately I am no longer at AWS nor on the project, so I am unable to assist on this matter

bryantbiggs avatar Sep 29 '25 14:09 bryantbiggs

Hi there, does anyone can urge the approve of the merge request open since two weeks by @dennisameling ? Appreciate it

MatteoNDR avatar Oct 08 '25 08:10 MatteoNDR

Unfortunately I am no longer at AWS nor on the project, so I am unable to assist on this matter

So, who is supposed to be in charge of managing this project from now on?

LeoSpyke avatar Oct 27 '25 11:10 LeoSpyke

Unfortunately I am no longer at AWS nor on the project, so I am unable to assist on this matter

So, who is supposed to be in charge of managing this project from now on?

https://github.com/aws-ia/terraform-aws-eks-blueprints-addons/blob/main/.github/CODEOWNERS

bryantbiggs avatar Oct 27 '25 12:10 bryantbiggs

Unfortunately I am no longer at AWS nor on the project, so I am unable to assist on this matter

So, who is supposed to be in charge of managing this project from now on?

https://github.com/aws-ia/terraform-aws-eks-blueprints-addons/blob/main/.github/CODEOWNERS

What does it mean exactly? Are you talking about those people?

LeoSpyke avatar Oct 28 '25 09:10 LeoSpyke

the groups are not public but that is the group that is responsible for the project

(for example, I used to be a part of that group when I was employed at AWS)

bryantbiggs avatar Oct 28 '25 12:10 bryantbiggs

@

This issue should definitely get the highest priority

we are not able to update to helm provider version ~> 3.1 due to the issues in this module. Any chance of getting the provider updates in the near time for hashicorp/aws to ">= 6.0" and hashicorp/helm to ">=3.0" versions

giri0211 avatar Nov 21 '25 09:11 giri0211