aws-greengrass-gdk-cli
aws-greengrass-gdk-cli copied to clipboard
Added support for using Gradle wrapper scripts
Description of changes: Added support for using Gradle wrapper scripts AKA "./gradlew"
Why is this change necessary: Gradle wrappers enforce that a build uses the proper version of Gradle. Without this change components will be built with the system's Gradle command which may be the wrong version.
How was this change tested: I built a component locally with it
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Additional tests should be added to make sure that ./gradlew is called instead of gradle when using this configuration.
Thank you for your contribution. PR looks good to me. But to proceed further, you need to make the following changes -
-
Update the commit messages to match the conventional commits format for the GitHub workflow checks to pass. You can also refer to the previous commits of this repository.
-
Add relevant unit tests and integration tests to maintain the code coverage of the repository so the codecov can pass.
-
Once you're done with 1 and 2, one of the Greengrass engineers will add UATs (mainly test data) for the same.
Also feel free to link this issue https://github.com/aws-greengrass/aws-greengrass-gdk-cli/issues/84 in your PR that you're addressing this. Let us know if you need more information.
Codecov Report
Base: 99.66% // Head: 99.66% // No change to project coverage :thumbsup:
Coverage data is based on head (
fa92aa2) compared to base (d3b380c). Patch coverage: 100.00% of modified lines in pull request are covered.
Additional details and impacted files
@@ Coverage Diff @@
## development #96 +/- ##
============================================
Coverage 99.66% 99.66%
============================================
Files 18 18
Lines 904 904
============================================
Hits 901 901
Misses 3 3
| Flag | Coverage Δ | |
|---|---|---|
| integ | 90.37% <100.00%> (ø) |
|
| uat | ? |
|
| unit | 99.11% <100.00%> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| gdk/commands/component/BuildCommand.py | 100.00% <100.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.