aws-greengrass-gdk-cli icon indicating copy to clipboard operation
aws-greengrass-gdk-cli copied to clipboard

Added support for Gradle’s Kotlin DSL

Open timmattison opened this issue 3 years ago • 2 comments
trafficstars

Description of changes: Add support for Gradle's Kotlin DSL by adding "build.gradle.kts" to the list of build files GDK searches for when the build system is set to "gradle"

Why is this change necessary: Without this change anyone using Gradle's Kotlin DSL would receive an error message like the one below when attempting to run gdk component build:

[2022-03-17 22:00:20] WARNING - Could not find the artifact file 'HelloWorld-1.0.0.jar' in the build folder 'set()'.

How was this change tested: I built a Greengrass component that uses Gradle's Kotlin DSL and published it successfully

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

timmattison avatar Mar 18 '22 02:03 timmattison

Additional tests should be added to validate that Kotlin DSL scripts work properly. I can provide those scripts if necessary.

timmattison avatar Mar 18 '22 02:03 timmattison

Thank you for your contribution. PR looks good to me. But to proceed further, you need to make the following changes -

  1. Update the commit messages to match the conventional commits format for the GitHub workflow checks to pass. You can also refer to the previous commits of this repository.
  2. Add relevant unit tests and integration tests to maintain the code coverage of the repository so the codecov can pass.
  3. Once you're done with 1 and 2, one of the Greengrass engineers will add UATs (mainly test data) for the same.

Let us know if you need more information.

saranyailla avatar Apr 08 '22 18:04 saranyailla

Codecov Report

Base: 99.66% // Head: 99.66% // No change to project coverage :thumbsup:

Coverage data is based on head (783329d) compared to base (d3b380c). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##           development      #95   +/-   ##
============================================
  Coverage        99.66%   99.66%           
============================================
  Files               18       18           
  Lines              904      904           
============================================
  Hits               901      901           
  Misses               3        3           
Flag Coverage Δ
integ 90.37% <100.00%> (ø)
uat ?
unit 99.11% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gdk/commands/component/BuildCommand.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Feb 10 '23 00:02 codecov[bot]

Added UAT but the GitHub workflow won't run it because the PR originates from the external contributor.

saranyailla avatar Feb 10 '23 21:02 saranyailla