runtime
runtime copied to clipboard
aws-controllers-k8s
feat: Add Support for Ready Condition
Description of changes: Adding support for a Ready condition that is set after every reconciliation standardizes ACK's conditions. This condition will serve as a high level status check for users that want to use ACK alogside with other controllers (kro).
The existing conditions will remain unchanged, and will still be set on the resource as they have been in the past. With this change, you'll be seeing a new condition that brings all our conditions together.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
@michaelhtm: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:
/test ec2-controller-test/test ecr-controller-test/test iam-controller-test/test s3-controller-test/test sagemaker-controller-test/test unit-test
The following commands are available to trigger optional jobs:
/test verify-attribution
Use /test all to run all jobs.
In response to this:
/test s3-controller
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
![ack-prow[bot] avatar](https://avatars.githubusercontent.com/in/260409?v=4 "Published by a pub.dev verified publisher"){kind=small}
@michaelhtm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| verify-attribution | e9d31f6dff9c97c144cab0c6077df0ee72085ac7 | link | false | /test verify-attribution |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: a-hilaly, michaelhtm
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [a-hilaly,michaelhtm]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment