runtime icon indicating copy to clipboard operation
runtime copied to clipboard

feat: add `IAMRoleSelector` CRD/feature

Open a-hilaly opened this issue 2 months ago • 7 comments

Implements https://github.com/aws-controllers-k8s/community/pull/2628 (mostly)

Introduces a new IAMRoleSelector CRD that enables dynamic IAM role assignment based on namespace and resource type selectors. This feature provides an alternative to CARM for role selection and cannot be used simultaneously with CARM (enforced by validation).

Key components:

  • New IAMRoleSelector CRD with namespace and resource type selectors
  • Selector matching logic with AND between selector types, OR within arrays
  • Dynamic informer-based cache for IAMRoleSelector resources
  • Integration into the reconciler to override CARM role selection
  • Alpha feature gate (IAMRoleSelector) defaulting to disabled

Note: ResourceTypeSelector uses schema.GroupVersionKind in the API, which differs from the separate fields approach in the original types. This may need adjustment based on CRD generation requirements.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

a-hilaly avatar Sep 24 '25 06:09 a-hilaly

/retest

a-hilaly avatar Sep 24 '25 15:09 a-hilaly

/retest

a-hilaly avatar Sep 24 '25 18:09 a-hilaly

/retest

a-hilaly avatar Sep 26 '25 18:09 a-hilaly

/retest

a-hilaly avatar Sep 27 '25 16:09 a-hilaly

/retest

a-hilaly avatar Oct 07 '25 23:10 a-hilaly

/lgtm

michaelhtm avatar Nov 12 '25 00:11 michaelhtm

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [a-hilaly,michaelhtm]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ack-prow[bot] avatar Nov 12 '25 00:11 ack-prow[bot]

/test sqs-controller-test /test ecr-controller-test

michaelhtm avatar Nov 12 '25 01:11 michaelhtm

@a-hilaly: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
sagemaker-controller-test c55d9c0bd66acfe045cd82664b860f47e0be5a2e link true /test sagemaker-controller-test
verify-attribution 87ccfa6f1595ceceed9317d17fff2dfac937cceb link false /test verify-attribution
sqs-controller-test 87ccfa6f1595ceceed9317d17fff2dfac937cceb link true /test sqs-controller-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ack-prow[bot] avatar Nov 12 '25 01:11 ack-prow[bot]