runtime
runtime copied to clipboard
Feat/account region protection
Adds protection against attempting to manage AWS resources that exist in a different region or account than the controller is configured to use. This prevents accidental resource hijacking and provides clear error messages.
- Add
regionDrifted()andaccountDrifted()helper functions - Check for drift before creating resource manager in Reconcile
- Return terminal errors when drift is detected
- Add comprehensive tests for both region and account drift scenarios
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
/test unit-test
/retest
/retest
/retest
/test ecr-controller-test
/retest
/lgtm
/hold
/lgtm /unhold
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: a-hilaly, michaelhtm
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [a-hilaly,michaelhtm]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/test s3-controller-test
/test ec2-controller-test
@a-hilaly: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| verify-attribution | c271c639b047ae65ee3c2fbca29eaf4e7e0f40fa | link | false | /test verify-attribution |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
/test sagemaker-controller-test