runtime icon indicating copy to clipboard operation
runtime copied to clipboard

refactor: convert runtime tests from external to internal package tests

Open a-hilaly opened this issue 2 months ago • 10 comments

Change test files from runtime_test to runtime package to enable testing of package private functions. Remove ackrt import alias as tests now have direct access to runtime package symbols.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

a-hilaly avatar Sep 23 '25 03:09 a-hilaly

/retest

a-hilaly avatar Sep 23 '25 18:09 a-hilaly

/retest

a-hilaly avatar Sep 23 '25 22:09 a-hilaly

/test ec2-controller-test

michaelhtm avatar Sep 24 '25 00:09 michaelhtm

/retest

a-hilaly avatar Sep 24 '25 03:09 a-hilaly

/test ec2-controller-test

michaelhtm avatar Sep 24 '25 04:09 michaelhtm

/retest

a-hilaly avatar Sep 24 '25 04:09 a-hilaly

/retest

michaelhtm avatar Sep 24 '25 16:09 michaelhtm

/test ec2-controller-test

michaelhtm avatar Sep 24 '25 17:09 michaelhtm

/lgtm

michaelhtm avatar Nov 10 '25 19:11 michaelhtm

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [a-hilaly,michaelhtm]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ack-prow[bot] avatar Nov 10 '25 19:11 ack-prow[bot]

/retest

michaelhtm avatar Nov 10 '25 19:11 michaelhtm

/test ecr-controller-test

michaelhtm avatar Nov 10 '25 20:11 michaelhtm

/test iam-controller-test

michaelhtm avatar Nov 10 '25 20:11 michaelhtm

@a-hilaly: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
verify-attribution fb7fe0ae384c4fed016961ce0ec71a894df60c1c link false /test verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ack-prow[bot] avatar Nov 10 '25 20:11 ack-prow[bot]

/test iam-controller-test

michaelhtm avatar Nov 10 '25 20:11 michaelhtm