runtime icon indicating copy to clipboard operation
runtime copied to clipboard

Published 20 hours ago • verified publisher icon aws-controllers-k8s

feat: retrieve aws partition from callerIdentity

Open michaelhtm opened this issue 4 months ago • 3 comments

Description of changes: Retrieve Partition from sts Caller identity. This will help with the generation of ACK resource status, adding support for all partitions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

michaelhtm avatar Jul 30 '25 21:07 michaelhtm

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ack-prow[bot] avatar Jul 30 '25 21:07 ack-prow[bot]

tested in https://github.com/aws-controllers-k8s/s3-controller/pull/173

michaelhtm avatar Aug 01 '25 19:08 michaelhtm

@michaelhtm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
verify-attribution f7ca6ab251ea8a9347819c17704b67e166386e8c link false /test verify-attribution
ecr-controller-test f7ca6ab251ea8a9347819c17704b67e166386e8c link true /test ecr-controller-test
sagemaker-controller-test f7ca6ab251ea8a9347819c17704b67e166386e8c link true /test sagemaker-controller-test
iam-controller-test f7ca6ab251ea8a9347819c17704b67e166386e8c link true /test iam-controller-test
s3-controller-test f7ca6ab251ea8a9347819c17704b67e166386e8c link true /test s3-controller-test
ec2-controller-test f7ca6ab251ea8a9347819c17704b67e166386e8c link true /test ec2-controller-test
sqs-controller-test f7ca6ab251ea8a9347819c17704b67e166386e8c link true /test sqs-controller-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ack-prow[bot] avatar Nov 11 '25 17:11 ack-prow[bot]