runtime icon indicating copy to clipboard operation
runtime copied to clipboard

chore: Use client instead of APIReader + Add observedGeneration to status Conditions

Open michaelhtm opened this issue 4 months ago • 8 comments

Description of changes: Currently in ACK, at the beginning of the Reconciler for each event, we get the resource from the k8s APIServer. This is an unecessary call, as the latest object that triggered the reconciler is already stored in the informers cache.

With this change, we will be retrieving the resource from the cache instead of the APIServer.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

michaelhtm avatar Jul 17 '25 20:07 michaelhtm

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ack-prow[bot] avatar Jul 17 '25 20:07 ack-prow[bot]

/test iam-controller-test

michaelhtm avatar Jul 17 '25 21:07 michaelhtm

/test s3-controller-test

michaelhtm avatar Jul 17 '25 21:07 michaelhtm

/test sagemaker-controller-test

michaelhtm avatar Jul 17 '25 21:07 michaelhtm

/hold

michaelhtm avatar Jul 21 '25 21:07 michaelhtm

This PR should be release along with the observed generation condition work

a-hilaly avatar Jul 25 '25 19:07 a-hilaly

/retest

michaelhtm avatar Aug 07 '25 01:08 michaelhtm

@michaelhtm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
verify-attribution 73efccc7d7aae86720a2bd1a278757f7f17aebc0 link false /test verify-attribution
sqs-controller-test 73efccc7d7aae86720a2bd1a278757f7f17aebc0 link true /test sqs-controller-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ack-prow[bot] avatar Nov 11 '25 17:11 ack-prow[bot]