runtime
runtime copied to clipboard
chore: Use client instead of APIReader + Add observedGeneration to status Conditions
Description of changes: Currently in ACK, at the beginning of the Reconciler for each event, we get the resource from the k8s APIServer. This is an unecessary call, as the latest object that triggered the reconciler is already stored in the informers cache.
With this change, we will be retrieving the resource from the cache instead of the APIServer.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: michaelhtm
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [michaelhtm]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/test iam-controller-test
/test s3-controller-test
/test sagemaker-controller-test
/hold
This PR should be release along with the observed generation condition work
/retest
@michaelhtm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| verify-attribution | 73efccc7d7aae86720a2bd1a278757f7f17aebc0 | link | false | /test verify-attribution |
| sqs-controller-test | 73efccc7d7aae86720a2bd1a278757f7f17aebc0 | link | true | /test sqs-controller-test |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.